User talk:Citation bot/Archive 9
From Wikipedia, the free encyclopedia
| This is an archive of past discussions with User:Citation bot. Do not edit the contents of this page. If you wish to start a new discussion or revive an old one, please do so on the current talk page. |
| Archive 5 | ← | Archive 7 | Archive 8 | Archive 9 | Archive 10 | Archive 11 | → | Archive 15 |
journal = www.foobar.com → journal = Www.foobar.com
- Status
- {{fixed}}
- Reported by
- Headbomb {t · c · p · b} 14:00, 9 August 2018 (UTC)
- Type of bug
- Garbage in/Garbage out
- What happens
|journal=www.foobar.com→|journal=Www.foobar.com- What should happen
- no change
- Relevant diffs/links
- https://en.wikipedia.org/w/index.php?title=Nevskia&diff=854179323&oldid=854171535
- We can't proceed until
- Agreement on the best solution
The bot is not a human being, it cannot always deal with rubbish. Technically, DNS is not case sensitive, so it is not a bug. I guess we can add a check for "starts with www". AManWithNoPlan (talk) 14:08, 9 August 2018 (UTC)
$data='rubbish';
$data = $bot->process($data);
// $data now contains 'new rubbish'
- https://github.com/ms609/citation-bot/pull/524. AManWithNoPlan (talk) 21:10, 9 August 2018 (UTC)
convert work to journal in cite journal, convert work to magazine in cite magazine
I think the first one is already done (|work= → |journal=) in , but something similar should also be done in {{cite magazine}} (|work= → |magazine=). Headbomb {t · c · p · b} 16:21, 12 August 2018 (UTC)
- https://github.com/ms609/citation-bot/pull/550 AManWithNoPlan (talk) 01:27, 13 August 2018 (UTC)
{{fixed}}
Adding citeseerx url where citeseerx parameter exists
In edit one the bot added citeseerx. In edit two it added the url to the citeseerx paper. This seems like unnecissary, and it seems weird that a second run diectly after the previous run results in "more", and not everything is added during the first run.
https://en.wikipedia.org/w/index.php?title=Stephen_Hawking&diff=prev&oldid=854866425
--(t) Josve05a (c) 09:44, 14 August 2018 (UTC)
- https://github.com/ms609/citation-bot/pull/543 AManWithNoPlan (talk) 13:38, 14 August 2018 (UTC)
- Still does it , and also adds handle urls when hdl is already set. Headbomb {t · c · p · b} 05:05, 15 August 2018 (UTC)
- Yup. Until that pulls is pulled, it will still do that. :-( AManWithNoPlan (talk) 14:17, 15 August 2018 (UTC)
- New pull to actually fix it. https://github.com/ms609/citation-bot/pull/572 AManWithNoPlan (talk) 03:37, 16 August 2018 (UTC)
- Yup. Until that pulls is pulled, it will still do that. :-( AManWithNoPlan (talk) 14:17, 15 August 2018 (UTC)
- Still does it , and also adds handle urls when hdl is already set. Headbomb {t · c · p · b} 05:05, 15 August 2018 (UTC)
{{fixed}}
GIGO? PMID=0
- Status
- {{fixed}}
- Reported by
- Headbomb {t · c · p · b} 18:14, 14 August 2018 (UTC)
- Type of bug
- Inconvenience
- What happens
- bot adds nonsensical pmid=0
- What should happen
- add nothing when the identifier doesn't make sense
- Relevant diffs/links
- https://en.wikipedia.org/w/index.php?title=Keith_Reemtsma&diff=854920633&oldid=854920608
- We can't proceed until
- ConsensusMaintainer
The database does return zero for the PMID. https://eutils.ncbi.nlm.nih.gov/entrez/eutils/esummary.fcgi?tool=DOIbot&email=martins@gmail.com&db=pmc&id=2676591 AManWithNoPlan (talk) 19:22, 14 August 2018 (UTC)
- Pull submitted. https://github.com/ms609/citation-bot/pull/559 AManWithNoPlan (talk) 19:28, 14 August 2018 (UTC)
- Which did not work. New one. https://github.com/ms609/citation-bot/pull/566 AManWithNoPlan (talk) 14:16, 15 August 2018 (UTC)
N Y --> N y
- Status
- {{fixed}}
- Reported by
- Headbomb {t · c · p · b} 01:02, 15 August 2018 (UTC)
- What happens
- changes
|journal=... N Y...to|journal=... N y... - What should happen
- Keep N Y as N Y
- Relevant diffs/links
- https://en.wikipedia.org/w/index.php?title=Sj%C3%B6gren_syndrome&diff=prev&oldid=854968717
- We can't proceed until
- Agreement on the best solution
of --> Of
- Status
- {{fixed}}
- Reported by
- Headbomb {t · c · p · b} 05:13, 15 August 2018 (UTC)
- What happens
- changes
|journal=... of...to|journal=... Of ... - What should happen
- leave it alone
- Relevant diffs/links
- https://en.wikipedia.org/w/index.php?title=Albert_Marden&diff=prev&oldid=854992097
- We can't proceed until
- Agreement on the best solution
Possibly caused by the dot before 'Of'. It might be easier to add an exception for
- Ann of Math
- Ann of Math (2)
- Ann of Sci
- Ann. of Math.
- Ann. of Math. (2)
- Ann. of Sci.
which I believe are the only ones affected by this.Headbomb {t · c · p · b} 05:13, 15 August 2018 (UTC)
- Special case for "Ann. of " https://github.com/ms609/citation-bot/pull/565 AManWithNoPlan (talk) 14:30, 15 August 2018 (UTC)
More caps
Headbomb {t · c · p · b} 06:06, 15 August 2018 (UTC)
- Actually we already had the fur version. https://github.com/ms609/citation-bot/pull/565 AManWithNoPlan (talk) 14:30, 15 August 2018 (UTC)
{{fixed}}
Don't remove wikilinks from |title=, use |title-link= instead
Instead of removing wikilinks form |title=, the bot should add the link as |title-link=. https://en.wikipedia.org/w/index.php?title=Ignore_all_rules&diff=prev&oldid=855068220 was a bad edit. User:Josve05a 18:28, 15 August 2018 (UTC)
- I have added some code that adds support for title-link should be deployed at some point. https://github.com/ms609/citation-bot/pull/569 AManWithNoPlan (talk) 22:31, 15 August 2018 (UTC)
{{fixed}}
Invalid ISBN
The bot added an invalid ISBN in this edit. 978160558012X is not valid. Might be GiGo. (t) Josve05a (c) 06:42, 16 August 2018 (UTC)
- GIGO it is. That’s the crossref ISBN. https://api.crossref.org/v1/works/http://dx.doi.org/10.1145/1358628.1358871 Someone changed the ISBN 10 to a 13 and forgot that the check digit often changes. It certainly is never X! Since ISBN is a parity check and not an ECC type check we have no way of knowing what the error is. Also a few books have been assigned invalid ISBN by publishers over the years. That’s minor compared to the using the same ISBN for multiple books—which is one reason there is no {{cite ISBN}}. AManWithNoPlan (talk) 13:41, 16 August 2018 (UTC)
{{notabug}}
Invalid DOI
The bot added | doi = 10.4244/ | doi-broken-date = 2018-08-16 in this edit. Seem wrong. Shouldn't we validate doi's before adding to avoid garbage? (t) Josve05a (c) 07:41, 16 August 2018 (UTC)
- Personally, I prefer the garbage addition in cases like this. It make humans look for the real, non-garbage doi. Headbomb {t · c · p · b} 12:11, 16 August 2018 (UTC)
- I should note several things. That is a standards compliant DOI-a suffix of zero length is allowed. That is the DOI according to pubmed. It is clearly rubbish though. There has been a long discussion on this in the past and generally people seem to like dead DOIs since often you can google the string and find them. Although perhaps an empty suffix is pretty useless. AManWithNoPlan (talk) 13:16, 16 August 2018 (UTC)
- Once this is committed, the Bot will require that DOIs have at least one character in the suffix and one character in the prefix. https://github.com/ms609/citation-bot/pull/580 AManWithNoPlan (talk) 13:55, 16 August 2018 (UTC)
- I should note several things. That is a standards compliant DOI-a suffix of zero length is allowed. That is the DOI according to pubmed. It is clearly rubbish though. There has been a long discussion on this in the past and generally people seem to like dead DOIs since often you can google the string and find them. Although perhaps an empty suffix is pretty useless. AManWithNoPlan (talk) 13:16, 16 August 2018 (UTC)
{{fixed}}
Bibcodes are not expanded
- Status
- {{fixed}}
- Reported by
- Lithopsian (talk) 20:19, 5 March 2018 (UTC)
- Type of bug
- Inconvenience
- What happens
- Templates containing a bibcode are not expanded
- Replication instructions
- Run bot against 1 Camelopardalis which contains several unexpanded citations
- We can't proceed until
- A specific edit to the bot's code is requested below.
- Requested action from maintainer
- Figure out why it is failing on tool servers
{{cite journal|bibcode=1985A&AS...60...99W}} for those not wanting to look. AManWithNoPlan (talk) 00:13, 6 March 2018 (UTC)
- My data handling improvements have already fixed this bug on GitHub development branch AManWithNoPlan (talk) 03:52, 6 March 2018 (UTC)
- Is not filling in the bibcode when, for example, expanding from doi also fixed by this?
- Tested with 2018/07/23 release, appears not fixed. Lithopsian (talk) 14:31, 24 July 2018 (UTC)
- This is not fixed on Wikipedia servers, but it seems to work on the Travis servers and at home. Strange. AManWithNoPlan (talk) 02:39, 29 July 2018 (UTC)
- We've been granted extra requests, and I plan to refactor the code in the future so it makes better use of them. Marking as {{fixed}}. Martin (Smith609 – Talk) 09:42, 3 August 2018 (UTC)
- I just tried it on User:Headbomb/sandbox3... doesn't seem to work. Headbomb {t · c · p · b} 12:03, 3 August 2018 (UTC)
- Does not work for me either. I wonder if he forgot key. AManWithNoPlan (talk) 13:05, 3 August 2018 (UTC)
Expand citation: - Checking AdsAbs database x PHP_ADSABSAPIKEY environment variable not set. Cannot query AdsAbs. [..> yadsabs]: no record retrieved. [..> rossref] - Checking CrossRef database for doi. [..> indpmid] - Searching PubMed... nothing found.
Possibly related, there seems to be something weird with that log beyond the key not being set.
..> yadsabs]: no record retrieved. [..> Crossref] (stray y? Missing C?). Headbomb {t · c · p · b} 19:49, 14 August 2018 (UTC)
- that’s debug information compressed to seven letters or less. AManWithNoPlan (talk) 02:32, 17 August 2018 (UTC)
It seems to be down right now
500 Internal Server Error AManWithNoPlan (talk) 04:43, 17 August 2018 (UTC)
- {{fixed}} AManWithNoPlan (talk) 13:14, 17 August 2018 (UTC)
Whitelist all whitelisted parameters
See Module:Citation/CS1/Whitelist for a list. Can't we invoke this list somehow instead of a manually maintaining one on GitHub? (t) Josve05a (c) 08:11, 27 July 2018 (UTC)
- we are very aware of that page. We could https a copy and then use http://php.net/manual/en/lua.call.php to run it or we could parse it with php if we are gutsy. another idea is to have a process update the list automatically and make a git pull. AManWithNoPlan (talk) 13:21, 27 July 2018 (UTC)
- is it possible to directly run wiki lua files on the tool server without https getting them? AManWithNoPlan (talk) 13:25, 27 July 2018 (UTC)
https://github.com/ms609/citation-bot/pull/599 AManWithNoPlan (talk) 17:55, 19 August 2018 (UTC)
Fixed AManWithNoPlan (talk) 00:02, 21 August 2018 (UTC)
Bot does not always do what it says it is going to do
- Status
Fixed- Reported by
- Martin (Smith609 – Talk) 14:57, 17 August 2018 (UTC)
- Type of bug
- Improvement
- What happens
- In this citation
Lucas (2015). "Thinopus and a Critical Review of Devonian Tetrapod Footprints". Ichnos. 22 (3–4): 136–154. doi:10.1080/10420940.2015.1063491.
the bot reports "~ Recognized DOI in URL; dropping URL", but doesn't drop the URL.
- What should happen
- It should probably drop the URL, or perhaps not say that it's about to.
- Relevant diffs/links
- https://en.wikipedia.org/w/index.php?title=Devonian&diff=prev&oldid=855333297
https://github.com/ms609/citation-bot/pull/589 AManWithNoPlan (talk) 15:41, 17 August 2018 (UTC)
Category API is crap
- Status
Fixed- Reported by
- Headbomb {t · c · p · b} 20:06, 17 August 2018 (UTC)
- Type of bug
- Improvement
- What happens
- Running the bot on a category produced a huge mess of text on a webpage. Only one page is expanded. Need the slow option.
- Relevant diffs/links
- https://tools.wmflabs.org/citations/category.php?cat=AfC_submissions_by_date/01_August_2017
It always has been, the weight of tradition is against you. 😬😄😂😆😜😏 AManWithNoPlan (talk) 20:52, 17 August 2018 (UTC)
- The problem is that the tool outputs text, not HTML. HTML ignores linefeeds. It really is designed to be run on the command line. AManWithNoPlan (talk) 20:55, 17 August 2018 (UTC)
- It also seems to not edit the majority of articles it could edit. I'll investigate further, but it seems running the bot on individual articles in a category yield more edits. BTW, the new API for the single page run is beautiful. Headbomb {t · c · p · b} 20:56, 17 August 2018 (UTC)
- The category code runs in FAST mode, that nice little check box that defaults to SLOW is not an option. AManWithNoPlan (talk) 21:06, 17 August 2018 (UTC)
- That's certainly a bummer. Maybe it should be. Headbomb {t · c · p · b} 21:08, 17 August 2018 (UTC)
- I had them change the "Expand citations" link off to the left size to that mode a while back. At least a "&slow=1" option should probably be added. AManWithNoPlan (talk) 21:09, 17 August 2018 (UTC)
- I shall take the fact that your complaint is "The formatting of the logfile offends my sensibilities" as a compliment to the current state of the bot. AManWithNoPlan (talk) 21:11, 17 August 2018 (UTC)
- https://github.com/ms609/citation-bot/pull/596 AManWithNoPlan (talk) 22:06, 17 August 2018 (UTC)
- https://github.com/ms609/citation-bot/pull/598 AManWithNoPlan (talk) 22:12, 17 August 2018 (UTC)
- https://github.com/ms609/citation-bot/pull/596 AManWithNoPlan (talk) 22:06, 17 August 2018 (UTC)
- I shall take the fact that your complaint is "The formatting of the logfile offends my sensibilities" as a compliment to the current state of the bot. AManWithNoPlan (talk) 21:11, 17 August 2018 (UTC)
- I had them change the "Expand citations" link off to the left size to that mode a while back. At least a "&slow=1" option should probably be added. AManWithNoPlan (talk) 21:09, 17 August 2018 (UTC)
- That's certainly a bummer. Maybe it should be. Headbomb {t · c · p · b} 21:08, 17 August 2018 (UTC)
- The category code runs in FAST mode, that nice little check box that defaults to SLOW is not an option. AManWithNoPlan (talk) 21:06, 17 August 2018 (UTC)
- It also seems to not edit the majority of articles it could edit. I'll investigate further, but it seems running the bot on individual articles in a category yield more edits. BTW, the new API for the single page run is beautiful. Headbomb {t · c · p · b} 20:56, 17 August 2018 (UTC)
- Turning on slow mode did more https://en.wikipedia.org/w/index.php?title=Draft%3ADr._Erick_Jones&type=revision&diff=855458969&oldid=855458884 AManWithNoPlan (talk) 13:03, 18 August 2018 (UTC)
- What's the syntax? https://tools.wmflabs.org/citations/category.php?cat=GATEGORY&slow=1 ? Headbomb {t · c · p · b} 13:35, 18 August 2018 (UTC)
- yes AManWithNoPlan (talk) 19:39, 18 August 2018 (UTC)
- Just following this discussion, when I run it like this it only analyzes 1 page in the category. Retrying it makes it run on one more article etc etc. Redalert2fan (talk) 19:47, 18 August 2018 (UTC)
- What full URL are you using? AManWithNoPlan (talk) 20:13, 18 August 2018 (UTC)
- For example: https://tools.wmflabs.org/citations/category.php?cat=Electric_multiple_units_of_Japan&slow=1 Redalert2fan (talk) 20:15, 18 August 2018 (UTC)
- What full URL are you using? AManWithNoPlan (talk) 20:13, 18 August 2018 (UTC)
- Just following this discussion, when I run it like this it only analyzes 1 page in the category. Retrying it makes it run on one more article etc etc. Redalert2fan (talk) 19:47, 18 August 2018 (UTC)
- yes AManWithNoPlan (talk) 19:39, 18 August 2018 (UTC)
- What's the syntax? https://tools.wmflabs.org/citations/category.php?cat=GATEGORY&slow=1 ? Headbomb {t · c · p · b} 13:35, 18 August 2018 (UTC)
- interesting. It only works on one page and stops. AManWithNoPlan (talk) 21:33, 18 August 2018 (UTC)
- The same happens without &slow=1 , it seems categories are broken... Redalert2fan (talk) 08:53, 19 August 2018 (UTC)
- Broken for a long time actually. AManWithNoPlan (talk) 18:08, 19 August 2018 (UTC)
- https://github.com/ms609/citation-bot/pull/612 AManWithNoPlan (talk) 18:59, 19 August 2018 (UTC)
- Broken for a long time actually. AManWithNoPlan (talk) 18:08, 19 August 2018 (UTC)
- The same happens without &slow=1 , it seems categories are broken... Redalert2fan (talk) 08:53, 19 August 2018 (UTC)
Multiple pages now fixed. AManWithNoPlan (talk) 02:04, 20 August 2018 (UTC)
category output is ugly and generally useless
Failed to capitalize when there's an & ?
Do not add / remove class
- Status
Fixed- Reported by
- Headbomb {t · c · p · b} 01:04, 18 August 2018 (UTC)
- Type of bug
- Improvement
- What happens
- The bot adds
|class=to cite journal.|class=is a parameter that's only useful in {{cite arxiv}} (and possibly {{citation}}, although that's bad practice). - What should happen
- The bot should not add
|class=in {{cite journal}} or others, and should remove it when encountered. It should only add it to {{cite arxiv}}, and only keep it in {{cite arxiv}} and {{citation}}. But if there's a|doi=in {{citation}}, remove|class=. - Relevant diffs/links
- https://en.wikipedia.org/w/index.php?title=Precision_tests_of_QED&type=revision&diff=855399984&oldid=854172669
https://github.com/ms609/citation-bot/pull/601 AManWithNoPlan (talk) 17:58, 19 August 2018 (UTC)
- For User:Smith609 asking for consensus, see this thread. Headbomb {t · c · p · b} 00:20, 20 August 2018 (UTC)
Remove location in cite journal
- Status
Fixed- Reported by
- Headbomb {t · c · p · b} 13:37, 18 August 2018 (UTC)
- Type of bug
- Improvement
- What happens
- Bot removes
|publisher=, but not|location= - What should happen
- bot should remove
|location=as well - Relevant diffs/links
- https://en.wikipedia.org/w/index.php?title=Draft:James_Joachim_Hurtak&curid=41551844&diff=855462164&oldid=849448384
https://github.com/ms609/citation-bot/pull/600 AManWithNoPlan (talk) 18:34, 18 August 2018 (UTC)
Remove stray commas at the end of title
https://github.com/ms609/citation-bot/pull/611 AManWithNoPlan (talk) 18:20, 19 August 2018 (UTC)
Capitalization is hard
Los Angeles should not be changed to los Angeles in |journal= as in https://en.wikipedia.org/w/index.php?title=Smilodon&diff=prev&oldid=855615980 (t) Josve05a (c) 16:26, 19 August 2018 (UTC)
- https://github.com/ms609/citation-bot/pull/610 AManWithNoPlan (talk) 18:06, 19 August 2018 (UTC)
Fixed AManWithNoPlan (talk) 23:38, 20 August 2018 (UTC)
Use |title-link= for linked italicized titles as well
https://en.wikipedia.org/w/index.php?title=Tarrasch_Defense&diff=855512383&oldid=836004652 here the wikilink was just removed. (t) Josve05a (c) 21:16, 18 August 2018 (UTC)
- should remove italics too. AManWithNoPlan (talk) 21:22, 18 August 2018 (UTC)
- Italic markup should be removed from 'book' citations (
|work=or aliases not set) but a cs1|2 template with a wikilinked|title=and without|url=is perfectly legitimate; there is an article Modern Chess Openings so:{{Citation |last=de Firmian |first=Nick |authorlink=Nick de Firmian |year=2008 |title=[[Modern Chess Openings]] |edition=15th |publisher=McKay |isbn=978-0-8129-3682-7}}- de Firmian, Nick (2008), Modern Chess Openings (15th ed.), McKay, ISBN 978-0-8129-3682-7
- is a correctly formed citation. This form is supported by the cs1|2 documentation at Template:Citation#Title which read.
- Do not misunderstand my point here as a contradiction of what I wrote elsewhere. When the whole title is wikilinked, that is acceptable. But, when the title looks like this one from the other discussion, wikilinking is inappropriate:
|title=A definitive abelisaurid theropod dinosaur from the early Late Cretaceous of [[Patagonia]]
- —Trappist the monk (talk) 16:49, 19 August 2018 (UTC)
Fixed https://github.com/ms609/citation-bot/pull/604 AManWithNoPlan (talk) 18:03, 19 August 2018 (UTC)
Do not remove partial wikilinks in titles
In https://en.wikipedia.org/w/index.php?title=Donald_Trump&diff=prev&oldid=855512893 the bot changed
|title=[[Trump Revealed]]: The Definitive Biography of the 45th President
to
|title=Trump Revealed: The Definitive Biography of the 45th President
I don't belive this should be done. (t) Josve05a (c) 21:22, 18 August 2018 (UTC)
- These links are almost always wrong. They are things like title=[[Trump]] [[Revealed]]: The Definitive Biography of the 45th [[President]]. AManWithNoPlan (talk) 18:01, 19 August 2018 (UTC)
- Yes, but in cases of human error/garbage input, a bot should not be the arbitor of what is and what isn't correct. In this case it is correct, yet the bot will continue to bot war unless specifically told not to edit the page. (t) Josve05a (c) 19:15, 19 August 2018 (UTC)
- Or you can use
|title-link=Trump Revealed. Headbomb {t · c · p · b} 00:25, 20 August 2018 (UTC)- That would link the entire content of the
|title=. In this case that is perhaps an acceptable solution, but not in all. (t) Josve05a (c) 01:06, 20 August 2018 (UTC)- good idea. If more than one link remove. Otherwise expand to whole text. That will encourage people to fix bad ones AManWithNoPlan (talk) 02:06, 20 August 2018 (UTC)
- That would link the entire content of the
- Or you can use
https://github.com/ms609/citation-bot/pull/620 AManWithNoPlan (talk) 17:31, 20 August 2018 (UTC)
Fixed AManWithNoPlan (talk) 23:38, 20 August 2018 (UTC)
Caps: da --> Da
Bot added invalid ISBN
- Status
Won't fix- Reported by
- – Jonesey95 (talk) 19:12, 19 August 2018 (UTC)
- Type of bug
- Inconvenience: Humans must occasionally make immediate edits to clean up after the bot
- What happens
- For doi:10.1145/1358628.1358871, the bot added the invalid ISBN 978160558012X
{{isbn}}: Checkisbnvalue: invalid character (help). - What should happen
- The actual ISBN as listed on the DOI page is 978-1-60558-012-8. Perhaps this is GIGO from a different source.
- Relevant diffs/links
- https://en.wikipedia.org/w/index.php?title=Wikipedia_administrators&type=revision&diff=855141849&oldid=854788406
Not a bug the ISBN in the metadata is 978160558012X sadly. https://api.crossref.org/v1/works/http://dx.doi.org/10.1145/1358628.1358871 AManWithNoPlan (talk) 19:19, 19 August 2018 (UTC)
- Just because it is invalid does not mean that it is wrong, such as the evil ISBN 0-7315-0342-1
{{isbn}}: ignored ISBN errors (link) which are tracked in https://en.wikipedia.org/wiki/Category:Pages_with_listed_invalid_ISBNs AManWithNoPlan (talk) 20:13, 19 August 2018 (UTC)
Clean up PMC
- Status
- new bug
- Reported by
- (t) Josve05a (c) 22:37, 19 August 2018 (UTC)
- Type of bug
- Improvement
- What should happen
- The bot should replace
|PMC=PMC3814821with|PMC=3814821. See Category:CS1 maint: PMC format. - We can't proceed until
- Agreement on the best solution
https://github.com/ms609/citation-bot/pull/616 AManWithNoPlan (talk) 14:26, 20 August 2018 (UTC)
Fixed AManWithNoPlan (talk) 00:01, 21 August 2018 (UTC)
|editorn-first=
|editor-lastn= and |editor-firstn= is the recognized paramenter, while |editorn-first= (and last) is an alias - not the other way around. The bot should not change |editorn-first= to |editor-firstn= as in https://en.wikipedia.org/w/index.php?title=Rhagonycha_greeni&diff=prev&oldid=855515605 (t) Josve05a (c) 21:49, 18 August 2018 (UTC)
- There is no reason to change these parameters from one legitimate form to another legitimate for except to unify the form within the template. This applies to all multi word enumerated parameters:
|author-mask6=,|interviewer5-link=, etc - —Trappist the monk (talk) 16:58, 19 August 2018 (UTC)
- this is because the citation templates have sooo many parameter choices. This pull now will add all of them and will also add a check to make sure that we notice any new ones. AManWithNoPlan (talk) 17:56, 19 August 2018 (UTC)
- https://github.com/ms609/citation-bot/pull/599 AManWithNoPlan (talk) 18:07, 19 August 2018 (UTC)
- this is because the citation templates have sooo many parameter choices. This pull now will add all of them and will also add a check to make sure that we notice any new ones. AManWithNoPlan (talk) 17:56, 19 August 2018 (UTC)
Fixed AManWithNoPlan (talk) 00:02, 21 August 2018 (UTC)
More caps
https://github.com/ms609/citation-bot/pull/619/files AManWithNoPlan (talk) 16:26, 20 August 2018 (UTC)
Fixed AManWithNoPlan (talk) 23:39, 20 August 2018 (UTC)
ISBN numbers
- Status
Not a bug- Reported by
- Gderrin (talk) 01:53, 20 August 2018 (UTC)
- What happens
- It is probably of little consequence, but this bot is changing ISBN numbers from the number given in the actual frontispiece of the books concerned (or at least the books I have quoted in articles). For example, the ISBN number given in "Verticordia, the turner of hearts" in Verticordia subg. Verticordia is 1 876268 46 8, but the bot has changed it to 978-1-876268-46-6. (The former number is used in more than 100 Verticordia articles.) Similarly it has changed 0 646 402439 to 978-0646402437 in Melaleuca shiressii. Both numbers seem to work but I wonder the purpose of changing. No big deal - just curious. Gderrin (talk) 02:52, 20 August 2018 (UTC)
Are referring to the ISBN 10 to 13 fixing? AManWithNoPlan (talk) 01:59, 20 August 2018 (UTC)
- also white space should not be used in isbn, so we remove it AManWithNoPlan (talk) 19:03, 20 August 2018 (UTC)
Google Books in Cite Web are not expanded
Yup. Note that for google books URLs, cite web won't expand, but cite book will expand. Headbomb {t · c · p · b} 15:00, 20 August 2018 (UTC)
- I absolutely hate having to manually change those to cite book..... Not sure why I did not do this sooner: https://github.com/ms609/citation-bot/pull/617 AManWithNoPlan (talk) 15:22, 20 August 2018 (UTC)
Bot adds doi url
- Status
Fixed in GitHub Pull 618- Reported by
- Headbomb {t · c · p · b} 15:21, 20 August 2018 (UTC)
- Type of bug
- Improvement: The bot would be much better if ...
- What happens
- Bot adds
|url=http://doi.org/10.1007/s12668-011-0022-5 - What should happen
- Bot adds
|doi=10.1007/s12668-011-0022-5 - Relevant diffs/links
- We can't proceed until
- Agreement on the best solution
https://github.com/ms609/citation-bot/pull/618 AManWithNoPlan (talk) 15:37, 20 August 2018 (UTC)
Fixed AManWithNoPlan (talk) 00:01, 21 August 2018 (UTC)
Translator link -> last##
- Status
Fixed- Reported by
- Martin (Smith609 – Talk) 14:59, 21 August 2018 (UTC)
- What happens
- translator-link replaced with translator-last##
- What should happen
- We should never see ##s, which are placeholders
- Relevant diffs/links
- https://en.wikipedia.org/w/index.php?title=Galileo_Galilei&diff=prev&oldid=855892437
- The bot ran during a git pull and so the files were in an inconsistent state. AManWithNoPlan (talk) 15:16, 21 August 2018 (UTC)
work parameter
Making edits such as https://en.wikipedia.org/w/index.php?title=Katarzyna_Bachleda-Curuś&diff=prev&oldid=855644962 may be a violation of Wikipedia:COSMETICBOT. (t) Josve05a (c) 20:49, 19 August 2018 (UTC)
- I don't really understand why the bot would remove parameters like that there. Not only is it cosmetic, the edit doesn't make sense. --Izno (talk) 20:56, 19 August 2018 (UTC)
- It is done to discourage the use of the generic and often misused
|work=. In almost all cases, the|journal=,|website=, etc. are better choices. Also, in this case|publisher=is already set to the wrong thing, it should use|website=instead, which is an alias for|work=. AManWithNoPlan (talk) 21:17, 19 August 2018 (UTC)- I will work on code to do a better job. AManWithNoPlan (talk) 21:20, 19 August 2018 (UTC)
- Here is the improvement. https://github.com/ms609/citation-bot/pull/614 If an alias of
|work=is filled in, the the empty|work=will be removed to discourage future adding of it which would be an error. If an alias of|work=is not set, then it will be changed to a template specific parameter if relevant: for example inf {{cite journal}} the empty|work=will be changed to an empty|journal=. AManWithNoPlan (talk) 21:37, 19 August 2018 (UTC)- Just ensure it is compliant with Wikipedia:COSMETICBOT or have gotten Wikipedia:BAG approval to be making edits which will make no appearance difference. (t) Josve05a (c) 21:42, 19 August 2018 (UTC)
- WP:COSMETICBOT compliance is good for large-scale runs, but since the bot is user activated, it's not that big a deal if the bot does minor cleanup like that on select, user-requested pages. There's tons of cosmetic things (e.g.
|page=→|pages=), which would in theory be nice to categorize as cosmetic, but this realistically would only be an issue if you run the bot on categories. So maybe in 'category mode', it should skip the cosmetic stuff. Seems a like a very high time cost for little payoff though at this time, but would matter if the bot started to edit on its own. Headbomb {t · c · p · b} 00:34, 20 August 2018 (UTC)
- WP:COSMETICBOT compliance is good for large-scale runs, but since the bot is user activated, it's not that big a deal if the bot does minor cleanup like that on select, user-requested pages. There's tons of cosmetic things (e.g.
- Just ensure it is compliant with Wikipedia:COSMETICBOT or have gotten Wikipedia:BAG approval to be making edits which will make no appearance difference. (t) Josve05a (c) 21:42, 19 August 2018 (UTC)
- Here is the improvement. https://github.com/ms609/citation-bot/pull/614 If an alias of
- I will work on code to do a better job. AManWithNoPlan (talk) 21:20, 19 August 2018 (UTC)
- It is done to discourage the use of the generic and often misused
Fixed AManWithNoPlan (talk) 00:02, 21 August 2018 (UTC)