Wikipedia:Bots/Requests for approval/Qwerfjkl (bot) 26

Discussion

The bot does not handle duplicate wikiprojects. It will treat them as distinct. — Qwerfjkltalk 18:08, 19 November 2023 (UTC)

• @Qwerfjkl: Hi. Is the source code publicly available (in your userspace or github)? With such a high number of pages effected, I think it should be. —usernamekiran (talk) 00:14, 20 November 2023 (UTC)
  • @Usernamekiran, it is publically avaliable on PAWS, here. I apologise if the code is messy. — Qwerfjkltalk 16:21, 20 November 2023 (UTC)
• I've done a few live tests of this to ensure the code works, and I've fixed a few more bugs. These edits can be found here. — Qwerfjkltalk 19:17, 20 November 2023 (UTC)
• Note: for consensus supporting these changes please see Wikipedia:Village pump (proposals)/Archive 198#Project-independent quality assessments and the various follow-up discussions on Template talk:WikiProject banner shell and its archives — Martin (MSGJ · talk) 21:03, 20 November 2023 (UTC)
• @Qwerfjkl: Which namespaces would you include? Talk, category talk, draft talk, and file talk? GoingBatty (talk) 16:30, 30 November 2023 (UTC)
• @Qwerfjkl: How does your code identify which templates are WikiProjects? Would it be beneficial to utilize User:Magioladitis/WikiProjects to convert redirects to {{WikiProject ...}} templates? GoingBatty (talk) 16:30, 30 November 2023 (UTC)
  • GoingBatty, I was planning on running it on all talk pages that could have WikiProjects i e the Talk, Category talk, Draft talk, File talk, Wikipedia talk, Help talk etc. namespaces).
    The code identifies which templates are redirects using the contents of Category:WikiProject banners without quality assessment, Category:WikiProject banners with quality assessment, Category:Inactive WikiProject banners.
    I haven't used User:Magioladitis/WikiProjects directly, instead I have just bypassed the redirects without regex (but it will still have the same effect).
    I have linked the code above which you can review. — Qwerfjkltalk 17:19, 30 November 2023 (UTC)

    The template redirects are not listed in those categories. I think GoingBatty was asking how you can identify these redirects. — Martin (MSGJ · talk) 13:32, 1 December 2023 (UTC)

    MSGJ, by checking WhatLinksHere and filtering it out by redirects in namespace 10 (Template). — Qwerfjkltalk 14:21, 1 December 2023 (UTC)

    Okay thanks, that sounds reasonable — Martin (MSGJ · talk) 21:41, 1 December 2023 (UTC)

• Please note that the module has been edited and now treats opt-out projects differently. It is no longer necessary to treat these banners differently, so I have struck point 8 above — Martin (MSGJ · talk) 14:37, 10 December 2023 (UTC)
  • MSGJ, I will update my code accordingly. — Qwerfjkltalk 15:12, 10 December 2023 (UTC)
  • MSGJ, okay, looking at this now, I assume this only holds if the opted-out WikiProject has a class that follows the standard quality assessments? That is to say, if the opted out WikiProject has a non-standard rating it still should be changed, is that right? — Qwerfjkltalk 10:51, 11 December 2023 (UTC)

    If it has the same rating as the PIQA rating then it can be removed. If it has a different rating, then it should be retained. (This is the same as all other projects, except that it won't be tracked as a conflicting rating.) — Martin (MSGJ · talk) 11:34, 11 December 2023 (UTC)

    MSGJ, okay, I've updated the code. By the way, is there a list of all the standard quality assessments somehwere? I just realised I should make sure the unified class is on the standard scale. — Qwerfjkltalk 11:39, 11 December 2023 (UTC)

    @Qwerfjkl: See Wikipedia:Content assessment. GoingBatty (talk) 14:56, 11 December 2023 (UTC)

    GoingBatty, are there any class aliases I need to look out for? Currently the values I check for are 'fa', 'ga', 'a', 'b', 'c', 'start', 'stub', 'list', and 'fl'. — Qwerfjkltalk 16:01, 11 December 2023 (UTC)

    @Qwerfjkl: I suggest upper case versions as well (e.g. "C", "Start"). GoingBatty (talk) 16:39, 11 December 2023 (UTC)

    GoingBatty, I've already made sure it's case insensitive (and whitespace insensitive). — Qwerfjkltalk 16:41, 11 December 2023 (UTC)

Approved for trial (100 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. In the interest of getting more eyes on this, please do not mark these as minor edits, and be sure to include a link to this page in the edit summary. Primefac (talk) 12:50, 14 December 2023 (UTC)

• Primefac, I am truly sorry, but I seem to have cocked this up. I did not realise that pywikibot saves edits as minor, and somehow the edit-limiting part of the code seems to have failed. You can see the edits here. There are 321 of them, including 100 before I realised I had set the bot to edit exactly one page (and for some reason the bot stopped at exactly 100 there). Again, I apologise for this mess. Martin, you may wish to look over the edits and see if there are any undesirable changes. I have checked a few of them.
  Here are some mistakes I noticed:
  • Talk:Mullah Omar - did not obey MOS:TALKORDER, happened again on Talk:Freddie Garrity
  • Talk:HMS Chesterfield (1745) - did not bypass the redirect to {{WPMILHIST}}
  • similar to above on Talk:Tisis bicolorella, this happened on quite a few pages
  • Talk:Zaghloul - stripped the disambig class from a disambiguation page. This happens because it doesn't have a standard content assessment - not sure if this is desirable?
  • Talk:Aaron Welles - it left the invisible comments behind when moving the WikiProjects. Not much I can do about this.
  • Talk:Trapped (2007 TV series) - cosmetic edit
  • Talk:Introduction to general relativity - moved {{Vital article}} into the WPBS. Is this desirable? On the bright side it applied MOS:TALKORDER correctly.
  This was just from a sample of the edits.
  I will fix these bugs soon. — Qwerfjkltalk 20:27, 14 December 2023 (UTC)

  Not too bad at all.

  • The main issue I see is the insertion of multiple new lines after the banner shell. This happened on many edits.
  • Yes I saw one or two TALKORDER violations.
  • The Disambig issue is something we are still discussing so it might be safer to keep them in for now.
  • A couple of times, the edit was cosmetic because the bot removed the "1="
  • User:Kanashimi is going to merge all the vital article templates, so doesn't really matter what happens to them now.

  — Martin (MSGJ · talk) 21:11, 14 December 2023 (UTC)

  MSGJ, regarding the multiple new lines issue, can you give a diff to clarify what you mean? For the Disambig issue, would you also suggest keeping other page type classes e.g. File class, Draft class, Category class? Currently I'm only running it on the main talkspace, but I assume it will also need to be run on other talkspaces.
  I'll make sure the bot doesn't make any more cosmetic edits. — Qwerfjkltalk 21:31, 14 December 2023 (UTC)

  No, Disambig is the only one causing an issue to detect — Martin (MSGJ · talk) 21:43, 14 December 2023 (UTC)

  Regarding the cosmetic issue, there isn't really an easy way to make sure the bot isn't making a cosmetic edit because it's doing so many different things. I'm not sure the added complexity would be worth it. — Qwerfjkltalk 12:42, 16 December 2023 (UTC)

  MSGJ, regarding the insertion of multiple new lines after the banner shell, I believe I know what you're referring to, but could you provide diff where this happened? — Qwerfjkltalk 12:20, 16 December 2023 (UTC)

  I already gave you the diff in the line above — Martin (MSGJ · talk) 14:26, 16 December 2023 (UTC)

  MSGJ, sorry, my mistake. Anyway that's fixed now, and I believe I have now sorted out all of the bugs from the trial (most of them were more straightforward than I expected). — Qwerfjkltalk 14:35, 16 December 2023 (UTC)

  Great, perhaps a further trial would be approved — Martin (MSGJ · talk) 08:41, 17 December 2023 (UTC)

  @Primefac? — Qwerfjkltalk 12:03, 17 December 2023 (UTC)

  Approved for extended trial (100 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete.

  Apologies, didn't realise this was out of trial and going needing to go back in. Primefac (talk) 14:16, 17 December 2023 (UTC)

  It was mentioned to me that Cewbot 12 is basically running the same task, but with extra features. Do you see any reason that both tasks should be running concurrently? I've struck the extended trial for now until that gets answered. Primefac (talk) 18:29, 17 December 2023 (UTC)

┌───────────────────────────┘
Primefac, I believe the plan was for Cewbot to run on vital article talk pages and my bot would handle the rest. My code has already been tested in previous bot tasks (#19). I'm also unsure that Cewbot has exactly the same functionality has mine (but I'm on my tablet right now and the code is 2000 lines long, so I might have missed something). Specifically I don't think Cewbot obeys MOS:TALKORDER (though as I said, I'm not entirely sure about this).
That said, if you feel it is unnecessary to have both bots run I will defer to your judgement. — Qwerfjkltalk 21:44, 17 December 2023 (UTC)

I think we can run together, after all, these templates a lot. cewbot follows MOS:TALKORDER, just for reference. Kanashimi (talk) 23:15, 17 December 2023 (UTC)

Fair enough. I've re-enabled the extended trial. Primefac (talk) 06:42, 18 December 2023 (UTC)

Primefac, Trial complete. See the latest edits here.
There were a few minor bugs (such as here where it added leading whitespace). The only non-cosmetic one that I could see was on Talk:Judicial Commission of Pakistan, where it didn't add the class because it treated a newline as a valid class. The only other bug was it not adding a blank |class= where the talk page already had a WikiProject banner shell but didn't have |class=.
I have fixed all of the bugs I found (described above). I also remembered not to make the edits minor this time. — Qwerfjkltalk 14:39, 18 December 2023 (UTC)

I'm not a bot operator but I noticed a non-cosmetic bug on Talk:Apple A14. I think reading the bot logic it should have added an empty class parameter for human assessment right? It just removed the 1=. PARAKANYAA (talk) 18:35, 18 December 2023 (UTC)

PARAKANYAA, yes, I noticed that one. I've fixed the bug. — Qwerfjkltalk 18:41, 18 December 2023 (UTC)

Looks good to me. Some minor issues:

• Please use |class=GA instead of |class=Ga
• On non-articles, there is no benefit in leaving the empty |class=
• This removed an {{image requested}} template
• Can line breaks in the listas and the next | be removed?

— Martin (MSGJ · talk) 21:07, 18 December 2023 (UTC)

MSGJ, can you clarify what you mean by the second one? All the talk pages are of articles. — Qwerfjkltalk 21:59, 18 December 2023 (UTC)

No? Redirects and disambiguation pages are not articles. Example — Martin (MSGJ · talk) 22:14, 18 December 2023 (UTC)

MSGJ, ah right, I see what you mean.
Regarding the {{image requested}} being removed, should it be kept in the WPBS or moved outside (and similarly for other non-WikiProject templates in the WPBS)? — Qwerfjkltalk 07:07, 19 December 2023 (UTC)

Any non-project banners (i.e. not produced with Module:WikiProject banner) should be moved outside the banner shell ideally — Martin (MSGJ · talk) 09:28, 19 December 2023 (UTC)

Is it possible for the bot to consolidate the banners into one line? At whoever added the banners added them in a non-conventional way, so now we are left with stuff like

{{WikiProject Rowing
|importance=Low
}}

Not an issue if it can't, just a "could be nice" to fix while the bot is working. Gonnym (talk) 09:27, 19 December 2023 (UTC)

Gonnym, this is kind of a GIGO situation that probably isn't worth fixing (I don't think it would be trivial to do so). — Qwerfjkltalk 15:09, 19 December 2023 (UTC)

Yeah, I had a feeling. Anyways, good job on the rest! Gonnym (talk) 15:12, 19 December 2023 (UTC)

I agree that would be nice. However there are banners which use a lot of parameters (e.g. MilHist) that display on multiple lines (example below). I don't think it would be received well if these parameters were bunched up

{{WPMILHIST|class=Start
<!-- B-Class 5-criteria checklist -->
| B1 <!-- Referencing and citations --> = n
| B2 <!-- Coverage and accuracy --> = n
| B3 <!-- Structure --> = n
| B4 <!-- Grammar and style --> = y
| B5 <!-- Supporting materials --> = y
|Historiography-task-force=yes}}

— Martin (MSGJ · talk) 12:44, 19 December 2023 (UTC)

Kanashimi, sorry, didn't see that. My mistake. — Qwerfjkltalk 14:33, 18 December 2023 (UTC)

That's all right. I think we should be able to work together. Kanashimi (talk) 21:12, 18 December 2023 (UTC)

• The current version of the code is at https://public-paws.wmcloud.org/User:Qwerfjkl%20(bot)/PIQA.ipynb. — Qwerfjkltalk 12:47, 16 December 2023 (UTC)
• MSGJ, I have now fixed all of those bugs. I have also updated the code to remove |class= from WikiProjects where it is empty, is this desirable? — Qwerfjkltalk 15:08, 19 December 2023 (UTC)

Break

Will your bot make edits like this? Although it is cosmetic, I think it would be beneficial because it discourages editors from using the class parameter in individual banners — Martin (MSGJ · talk) 12:41, 19 December 2023 (UTC)

• MSGJ, yes. It will override whatever class value the old WPBS had, if it can find one on the majority of WikiProjects that is different to the WPBS' one. — Qwerfjkltalk 15:12, 19 December 2023 (UTC)

  I don't understand your answer. In the example I gave, the WPBS already had class=start. I am asking if the redundant ones will be removed or if the bot will pass over this page? — Martin (MSGJ · talk) 17:14, 19 December 2023 (UTC)

  I do hope the bot will not be overriding the WPBS parameter in any event. That is for humans to review, if there is a conflict. — Martin (MSGJ · talk) 17:15, 19 December 2023 (UTC)

  MSGJ, to clarify:

  • Yes, the bot would remove the class parameters from the wikiprojects in that event.
  • The bot will override a pre-existing WPBS class if the one it finds is different from the one in the WPBS. (I assumed the one from the wikiprojects is more likely to be corrrect.) If this is undesirable I can change that.

  — Qwerfjkltalk 17:19, 19 December 2023 (UTC)

  Yes, that should not happen. If there is a |class= in WPBS then that has already been set by a human editor. — Martin (MSGJ · talk) 17:23, 19 December 2023 (UTC)

  MSGJ, Okay, I've changed that. — Qwerfjkltalk 18:27, 19 December 2023 (UTC)

@Qwerfjkl: the |living= or |blp= parameter can now be migrated to the banner shell, or just removed if it is already there (example) — Martin (MSGJ · talk) 18:27, 22 December 2023 (UTC)

• MSGJ, the bot already adds it to WPBS. Do you mean it should also be removed from WPBIO? — Qwerfjkltalk 18:35, 22 December 2023 (UTC)
  • Also, I assume this now applies no matter what value it has? Currently it only looks for "y" or "yes". — Qwerfjkltalk 21:20, 22 December 2023 (UTC)

    Yes |blp=no would be useful on biographies I think. It doesn't actually do anything but we can use it to track missing uses — Martin (MSGJ · talk) 21:48, 22 December 2023 (UTC)

    MSGJ, so what it would do is this:
    Remove |blp= or |living= from WPBIO.
    If WPBS has |blp=, stop there.
    Otherwise, if |blp=yes add that to the WPBS.
    If |blp=no and the article is a biography (which it will be because WPBIO is present) add that to the WPBS.
    If |blp= is anything else it will totally removed.
    It will always be removed from WPBIO.
    One other thing, what's the preferred class for disambiguation pages? I'm unsure which alias to use. — Qwerfjkltalk 22:26, 22 December 2023 (UTC)

    @MSGJ & @Qwerfjkl: Please don't remove |blp= or |living= from WPBIO, as you will be adding articles to Category:Biography articles without living parameter. Also, |living= is an alias of |blp= in WPBS. GoingBatty (talk) 23:31, 22 December 2023 (UTC)

    That shouldn't happen after my recent change GoingBatty — Martin (MSGJ · talk) 17:52, 23 December 2023 (UTC)

    MSGJ, please can you confirm I've got it right above, and answer my question? — Qwerfjkltalk 22:24, 23 December 2023 (UTC)

    That all looks good to me Qwerjkfl. I think we can use |blp= instead of |living=. Disambiguation pages will be automatically detected, so should not need a class in that case. — Martin (MSGJ · talk) 22:11, 26 December 2023 (UTC)

    MSGJ, ah, so we can now remove the class for dabs? Great.
    As |living= is an alias of |blp=, I assume I should treat it the same i.e. if WPBS has |living= I wouldn't add |blp= or change anything in the WPBS. — Qwerfjkltalk 10:45, 27 December 2023 (UTC)

    I'm also slightly concerned in cases like:

    • WPBIO has a different value from WPBS, so WPBIO's value will be removed, ignoring the conflicting values
    • WPBIO has an unexpected value (not "y", "yes", "n" or "no"), which would be removed

    Just want to make sure I've got this right now so it doesn't cause issues later down the line. — Qwerfjkltalk 10:49, 27 December 2023 (UTC)

    @MSGJ? — Qwerfjkltalk 08:33, 30 December 2023 (UTC)

    Not exactly sure what is best. I can set up a tracking category for these if you think it's needed? — Martin (MSGJ · talk) 22:58, 30 December 2023 (UTC)

    The method I use is to move it as is without conflict to avoid incorrect speculation. The tracking category can be added to WPBS. Kanashimi (talk) 23:41, 30 December 2023 (UTC)

    Yes, that works too. But can I suggest using |blp= rather than |living= (even though the latter is an alias of the former)? — Martin (MSGJ · talk) 17:45, 31 December 2023 (UTC)

┌──────────────────────────────┘
MSGJ, I've done that. It will not switch |living= over to |blp=, but it will prefer to use |blp= when adding it to the WPBS. — Qwerfjkltalk 17:47, 31 December 2023 (UTC)

That's great — Martin (MSGJ · talk) 17:49, 31 December 2023 (UTC)

E.g. search for Talk:Joshua Cooper (1732–1800) on https://public-paws.wmcloud.org/User:Qwerfjkl%20(bot)/PIQA.ipynb. — Qwerfjkltalk 17:55, 31 December 2023 (UTC)

{{BAG assistance needed}} I have just approved Cewbot 12, as it seems to have passed its trials with more aplomb than this task. I am looking for a second BAG opinion as I do not see a great need to approve both bots to do the same task, other than maybe the fact that the scope is essentially "every talk page with a banner shell". Primefac (talk) 13:36, 31 December 2023 (UTC)

• Primefac, I have now extensively tested this by doing dry runs (i.e. without editing). I am fairly confident there should be no more (significant) bugs. There may be some minor cosmetic ones / GIGO ones, but nothing that would really change anything. At https://public-paws.wmcloud.org/User:Qwerfjkl%20(bot)/PIQA.ipynb you can see a log of the most recent of these test (they are wiped every time I rerun the code). — Qwerfjkltalk 17:42, 31 December 2023 (UTC)

I believe it would be a good idea to have a second bot approved for this task, mainly because of the huge number of pages to be touched, sharing responsibility and avoiding reliance on one operator. I support the ramped deployment that Cewbot is using. — Martin (MSGJ · talk) 09:43, 4 January 2024 (UTC)

• Primefac, given the recent change to {{BAG assistance needed}}, you might want to try it again. — Qwerfjkltalk 10:04, 6 January 2024 (UTC)

  I had already cross-posted to BOTN so there wasn't much point. Primefac (talk) 14:23, 6 January 2024 (UTC)

A error has come to light and I have reinstated point 8 of the function details. Sorry for any confusion but what I wrote earlier was not quite accurate. — Martin (MSGJ · talk) 16:52, 2 January 2024 (UTC)

• MSGJ, I have restored the code for that. — Qwerfjkltalk 16:56, 2 January 2024 (UTC)

Approved. I would ask that you start slowly (maybe batches of <1000 per day) at the outset just to make sure any lingering issues that weren't seen in the trials can be dealt with. Primefac (talk) 14:23, 6 January 2024 (UTC)

The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at Wikipedia:Bots/Noticeboard.